search

demurgos / v8-coverage

Helpers to manipulate V8 coverage files
16 stars 6 forks source link

add opensource license? #68

Open kaizhu256 opened 2 years ago

kaizhu256 commented 2 years ago

hi, i'm interested in reusing the merge-code for an opensource html-reporter. could you add a LICENSE file for proper attribution (i see its MIT @ https://www.npmjs.com/package/@c88/v8-coverage)?

kaizhu256 commented 2 years ago

nvrmind, i see it @ https://github.com/demurgos/v8-coverage/blob/master/ts/LICENSE.md

demurgos commented 2 years ago

The license is also defined in the package.json, but I'll make sure to add a file at the root of the repo so it is diplayed properly on GitHub. (I am leaving the issue open until then)

kaizhu256 commented 2 years ago

k. fyi i attributed this repo for the html-reporter. thank you for making the feature possible in jslint!

demurgos commented 2 years ago

No problem! I am in the process of updating the package to release a 1.0 version for c8/jest. I'll make sure to send a PR to jslint too then.

bartlomieju commented 2 years ago

I ended up forking some of the Rust code and also added a comment linking back to this repo as well as a copyright: https://github.com/denoland/deno/pull/13334

Having a LICENSE file in repo would be helpful. Thanks for a very useful project!

HSH73 commented 1 year ago

Please add license info directly in repo overview, it makes things a lot easier - thanks!