feat(Seq)!: Add sequenceResultA, align sequenceResultM

demystifyfp / FsToolkit.ErrorHandling

An opinionated F# Library for error handling

https://demystifyfp.gitbook.io/fstoolkit-errorhandling

MIT License

462 stars 59 forks source link

feat(Seq)!: Add sequenceResultA, align sequenceResultM #255

Closed bartelink closed 5 months ago

bartelink commented 7 months ago

Implements #254

Add Seq.sequenceResultA
align signature of sequenceResultM with that of sequenceResultA (yield an Array, rather than accumulating in a list and upcasting via List.toSeq
add docs for sequenceResultM
remove FSharp.xml content file (noise when searching in Rider)

bartelink commented 7 months ago

Open to removing anything you consider an overstep - I'm not enjoying the fantomas ruleset so there is some letter of the law interpretations.

Please push back on anything that's not right!

have not actually fsi'd the doc samples, or looked at the gitbook

bartelink commented 7 months ago

I'd prefer not to make breaking changes here unless you want to retarget for https://github.com/demystifyfp/FsToolkit.ErrorHandling/pull/249

as mentioned in #254 I'm happy either way.

Adding it is not time-sensitive for me, so I'll leave it entirely up to you whether you want a) this PR based on v5 b) remove this diff and add a PR that can be merged later that does the contract change

I guess my slight preference is to stay with one PR, but I'm a maintainer too so I'd prefer you to make the call.

bartelink commented 7 months ago

The build wasn't happy for reasons I could not discern - happy to rebase or adjust this any time; just ping By the same token, if you want to make adjustments and/or just merge it, that's fine too