den1n / nova-queues

Queues resource for Laravel Nova.
MIT License
12 stars 8 forks source link

Update Retry.php #3

Closed ericphamhoangrz closed 3 years ago

ericphamhoangrz commented 3 years ago

hi mate, I tried this retry function on laravel 8.5 and it doesn't seem to work. it seems to me they use uuid instead of ID

php artisan queue:failed

return a table with Id = uuid

+--------------------------------------+------------+---------+-------------------------------------+---------------------+ | ID | Connection | Queue | Class | Failed At | +--------------------------------------+------------+---------+-------------------------------------+---------------------+ | b07ed27a-15b1-4a8c-afe6-a12c7e3102ea | database | default | App\Jobs\MyJob| 2021-07-30 11:33:14 | +--------------------------------------+------------+---------+-------------------------------------+---------------------+

I've tested this fix and it works on my end :)

den1n commented 3 years ago

Hi!

Laravel's documentation says:

The job ID may be used to retry the failed job.

So not UUID.

I think Retry action has an issue with passing the $id parameter to Artisan command.

I fixed it.

Can you update to v1.1.7 and check if the Retry action works?

Sorry, i cannot check it now.

ericphamhoangrz commented 3 years ago

Thanks mate. I've tried the new one but it still doesn't work

Even this one doesn't work either: (1 string) Artisan::call('queue:retry ' .$model->id);

so the id laravel mentioned is actually UUID

den1n commented 3 years ago

You right. I found that Laravel 8 uses 'database-uuids' driver by default in config/queue.php.

I added check for the driver before firing 'queue:retry' command.

Retry command should work now. I checked this time :)

Please update to v1.1.8.

ericphamhoangrz commented 3 years ago

It worked. thanks mate