search

denali-js / cli

The official CLI for starting, building, and running Denali apps and addons
MIT License
5 stars 5 forks source link

Adds '.env' to 'packageFiles' to be copied #16

Closed rtablada closed 7 years ago

rtablada commented 7 years ago

This is a potential solution to https://github.com/denali-js/denali/issues/283

But there should be discussion whether .env should be pulled into the build or loaded elsewhere.

davewasmer commented 7 years ago

I think we're going with the solution outlined here: https://github.com/denali-js/denali/issues/283#issuecomment-286637704

Basically, the CLI will load the .env file from the project root, which allows us to avoid copying it into the build (and potentially risking the unsuspecting user deploying sensitive secrets).