Spinners galore (AKA fix all the things with spinners)

denali-js / cli

The official CLI for starting, building, and running Denali apps and addons

MIT License

5 stars 5 forks source link

Spinners galore (AKA fix all the things with spinners) #25

Closed acburdine closed 7 years ago

acburdine commented 7 years ago

Note: this PR is based on #24 - once that one is merged I'll rebase this one but I thought i'd get the changes in so that they can be tested.

Tested this with denali as a child addon, going to do some more tests with other existing addons. Denali itself won't work out of the box just by adding isDevelopingAddon=true.... needs a separate PR to make it work as a development addon (PR: https://github.com/denali-js/denali/pull/340).

acburdine commented 7 years ago

👍 now that #24 is merged I'll rebase this