search

denali-js / core

An opinionated, ORM agnostic framework for building robust JSON APIs in Node
http://denalijs.org
Apache License 2.0
73 stars 14 forks source link

CLI arguments appear to not be properly typed #418

Open seawatts opened 6 years ago

seawatts commented 6 years ago

https://github.com/denali-js/denali/blob/82401b4517b94426c3d723981eafad6356fd39cf/commands/server.ts#L98

knownasilya commented 6 years ago

Args are always strings, so we need to do an explicit check here.

davewasmer commented 6 years ago

This line should be converting the arg to a typed variable. Perhaps this is a larger bug.

https://github.com/denali-js/denali/blob/82401b4517b94426c3d723981eafad6356fd39cf/commands/server.ts#L51

Updating the title to reflect