dendendenden04 / pe

0 stars 0 forks source link

Able to add duplicate deadlines #12

Open dendendenden04 opened 1 year ago

dendendenden04 commented 1 year ago

image.png

Steps to reproduce:

Add deadlines with the same description for both name and time description.

Expected outcome: Reject the duplicate deadlines Actual outcome: Added the duplicate deadlines to the deadline list.

Similar to the other bug for meetings [able to add duplicates] , I feel like this bug lies in between low and medium severity. Careless users are more likely to be inconvenienced as they might miss deadlines due to the duplicates, but I believe most users are able to remove duplicate deadlines themselves.

nus-pe-bot commented 1 year ago

Team's Response

This is a duplicate of the issue #978 as both issues mentions about adding of duplicate deadlines

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate deadlines can be added

image.png

From the SS, it can be seen that multiple of the exact same entries can be added and duplicate deadlines are not handled. This is a waste of memory.

Also, when a user deletes an index (from delete_meeting) then there may be a duplicate!! And the user may have forgetting whether or not he/she had attended that meeting later in the future.***

It is a functionality bug since legitimate user behavior is not handled e.g. incorrect commands, extra parameters

It has a severity of medium since it is a flaw that causes occasional inconvenience to some users (as explained above under ***).


[original: nus-cs2113-AY2223S2/pe-interim#786] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

though it is not in scope to check for duplicate of deadline description, i do agree that entries with the exact same description and time should not be allowed as it hard to differentiate.

I think the severity should be low as a normal user will not be adding the exact same deadline twice and if there indeed was an exact repeat, the deadline with the smaller index, which was added earlier, should be considered the actual one. Furthermore, the duplicated deadline can be removed by the user as well using the delete_deadline command

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]