Implemented multiple selections, linked scatterplot views.

dendrograms / astrodendro

Generate a dendrogram from a dataset

https://dendrograms.readthedocs.io/

Other

37 stars 36 forks source link

Implemented multiple selections, linked scatterplot views. #104

Closed tomr-stargazer closed 10 years ago

tomr-stargazer commented 10 years ago

I believe I implemented everything requested:

Multiple selections using 3 different mouse buttons (for me: click, alt-click, ctrl-click, respectively)
Scatter plots from the catalog data that are linked to the DendroViewer via a hub (@ChrisBeaumont helped much here) -- this is in dendro_scatter.py
Cosmetic changes to some of the above, using colorbrewer colors, more opacity, multiple SelectedLabels, and ensuring that smaller/higher-up structures always plot over larger/lower structures
Rebased into one commit (compare #103, #101, and #100, which have some screenshots and discussion).

The docs haven't been updated yet to reflect the new functionality, mainly since I'm not sure where to make such changes.

tomr-stargazer commented 10 years ago

@ChrisBeaumont @astrofrog As far as I can tell, this is ready to merge.

tomr-stargazer commented 10 years ago

Should I rebase these commits again into one commit before we merge?

ChrisBeaumont commented 10 years ago

The commit history looks good to me. I'll give it a test drive and last lookover. @astrofrog suggested you add a brief note to the documentation about the 3-mouse selection process, and maybe include an example of instantiating a scatter plot. Are you up for that?

tomr-stargazer commented 10 years ago

If you can point me to the relevant documentation files I should be editing, then yes I can handle that!

On Fri, Mar 14, 2014 at 12:52 PM, Chris Beaumont notifications@github.comwrote:

The commit history looks good to me. I'll give it a test drive and last lookover. @astrofrog https://github.com/astrofrog suggested you add a brief note to the documentation about the 3-mouse selection process, and maybe include an example of instantiating a scatter plot. Are you up for that?

Reply to this email directly or view it on GitHubhttps://github.com/dendrograms/astrodendro/pull/104#issuecomment-37669955 .

ChrisBeaumont commented 10 years ago

Maybe you could add a paragraph to https://github.com/dendrograms/astrodendro/blob/master/docs/plotting.rst#interactive-visualization

tomr-stargazer commented 10 years ago

@ChrisBeaumont I've updated the docs. How does that look? I could also include an image of a DendrogramViewer side-by-side with the linked DendroScatter, but is there a default datacube to render that on? (e.g. the one shown here -- https://github.com/dendrograms/astrodendro/blob/master/docs/plotting.rst#interactive-visualization )

ChrisBeaumont commented 10 years ago

Merged via #105.