search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 36 forks source link

Custom adjacency logic #108

Closed ChrisBeaumont closed 10 years ago

ChrisBeaumont commented 10 years ago

Closes #102

ChrisBeaumont commented 10 years ago

@tomr-stargazer see https://github.com/dendrograms/astrodendro/pull/108/files#diff-954e56aad15105e727c7776fcd9ee369R112 for an example of how to build wrapped dendrograms using this PR

astrofrog commented 10 years ago

Looks great! I presume you will remove the _offsets[3] line before merging?

ChrisBeaumont commented 10 years ago

Yeah, I can make it a comment (I think it helps illustrate what the comprehension does, so it's helpful for humans to see)

astrofrog commented 10 years ago

@ChrisBeaumont - I agree, making it a comment makes sense

tomr-stargazer commented 10 years ago

Thanks so much for this @ChrisBeaumont! Should I be concerned that the Travis build is failing, or would it be okay for me to check out this branch locally and start messing around anyway?

ChrisBeaumont commented 10 years ago

Hmm let's see if this commit fixes that. I lost a kwarg somewhere

ChrisBeaumont commented 10 years ago

I'm happy with this. @astrofrog and I talked about adding an example that uses this new functionality to make an all-sky healpix dendrogram by wrapping healpy. I'm ready to merge this PR, unless we think that example should go here as well

tomr-stargazer commented 10 years ago

Hi -- I'm curious if there are plans to merge this in soon?

ChrisBeaumont commented 10 years ago

If I don't hear objections from @astrofrog, I'll merge this this afternoon