search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 36 forks source link

PPP catalog #147

Open dcolombo opened 8 years ago

dcolombo commented 8 years ago

Ana Duarte-Cabral and I created a tentative version of PPP structure catalog.

The current implementation works only on the volumetric density-based simulated data cube used to generate the dendrogram. Simulated data cubes must be provided in units of g/cm3 or Msun/pc3. Classes needs mass.py script functions which provide the mass of the structures in Msun. This is basically a mirror of flux.py of PPV catalog.

The implementation has been tested on a chunk of Clare Dobbs' simulation and appears to provide the expected results.

keflavich commented 8 years ago

On the failures: there seems to be a travis configuration issue, which I'm attempting to fix here: https://github.com/dendrograms/astrodendro/pull/148

keflavich commented 8 years ago

Besides the few comments, this looks good to me. It would be helpful to have some tests, though.

smhr commented 3 years ago

Hello @keflavich and @dcolombo. I want to use PPP statistics to find the mass of structures (leaves) in a simulation outputs. I think this PR is very useful. But I see this PR has remained open since a long time. Could I use the fork safely? Has anyone tested it? Regards

pscicluna commented 2 years ago

Hi! I'm also interested in using this, so a status update would be handy. Are there things that I could do to help move this forward? Or should I be looking at re-writing the functionality that I need myself?