search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Added .travis.yml #15

Closed astrofrog closed 11 years ago

astrofrog commented 11 years ago

I think there will be some failures that need to be fixed before this can be merged.

astrofrog commented 11 years ago

The test that relies on the pickled values is not working in Python 3 due to byte/unicode errors, and I can't find a way to read it in properly. I think we should probably move away from using a pickle though - a gzipped ASCII file might be just as good.

@bradenmacdonald @ChrisBeaumont - what do you think?

ChrisBeaumont commented 11 years ago

Fine by me

astrofrog commented 11 years ago

Actually I decided to simply change it to a Numpy savez file, which is exactly the same size as before, but gets around the issues with bytes/unicode.

astrofrog commented 11 years ago

This now includes a fix in dendrogram.py - I simplified the code that finds the coordinates of the values by using np.where - this should fix the failure with Numpy 1.5 and earlier.

ChrisBeaumont commented 11 years ago

I <3 test suites

On Thu, Jun 13, 2013 at 11:52 AM, Thomas Robitaille < notifications@github.com> wrote:

This now includes a fix in dendrogram.py - I simplified the code that finds the coordinates of the values by using np.where - this should fix the failure with Numpy 1.5 and earlier.

— Reply to this email directly or view it on GitHubhttps://github.com/dendrograms/dendro-core/pull/15#issuecomment-19400962 .

Chris Beaumont Graduate Student Institute for Astronomy University of Hawaii at Manoa 2680 Woodlawn Drive Honolulu, HI 96822 www.ifa.hawaii.edu/~beaumont

astrofrog commented 11 years ago

All right, this should hopefully pass... fingers crossed!

astrofrog commented 11 years ago

Yay, all tests passing! \o/

@ChrisBeaumont - ok to merge this?

ChrisBeaumont commented 11 years ago

Looks good to me