search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Release 0.1 package #44

Closed astrofrog closed 10 years ago

astrofrog commented 11 years ago

GitHub will close the milestone if all issues are completed, so this ensures that the milestone stays open until the package is actually released. Leave any reminders here about anything release-related.

astrofrog commented 11 years ago

I think that we can consider releasing a first release before #47 is dealt with. As long as we are comfortable with the features we do offer, there's no need to wait to release. There are definitely a few other issues to deal with before release though.

ChrisBeaumont commented 11 years ago

Agreed that the general solution to #47 can wait, but I do think we need some kind of user friendly way to compute at least flux in 0.1. For now, perhaps we strictly require a single length/bunit metadata pair in specific units, and worry later about being more flexible?

Im reminded about an old conversation with Adam Leroy. When I told him you had ported dendrograms to python, he replied that the real obstacle to him leaving the IDL code was the lack of a levelprops/cprops port. Thus, I think a minimally complete cataloging module needs to be in 0.1, even if it isnt fully flexible/user friendly yet On Jul 12, 2013 5:59 AM, "Thomas Robitaille" notifications@github.com wrote:

I think that we can consider releasing a first release before #47https://github.com/dendrograms/dendro-core/issues/47is dealt with. As long as we are comfortable with the features we do offer, there's no need to wait to release. There are definitely a few other issues to deal with before release though.

— Reply to this email directly or view it on GitHubhttps://github.com/dendrograms/dendro-core/issues/44#issuecomment-20868175 .

astrofrog commented 11 years ago

I can try and implement a restrictive flux calculation for specific subsets of units. I think we could reasonably support flux density per pixel and flux density per area, but I think that things like flux density per beam or even worse, antenna temperature, will be trickier. So rather than require specific units, we could start with at least specific types of units. I'll try and work on this this afternoon and update #54.

What is needed to implement levelprops/cprops? (I've never used these, so I'm not familiar with them)

ChrisBeaumont commented 11 years ago

Levelprops is basically what exists in the analysis module (though it also estimates masses from co fluxes). Cprops takes things a little further, measures properties as a funtion of intensity, and extrapolates these to the intensity=0 contour. Cprops is advertised as less biased for isolated clumps, but I dont think it has been extended to deal with overlapping/hierarchical structures On Jul 12, 2013 7:47 AM, "Thomas Robitaille" notifications@github.com wrote:

I can try and implement a restrictive flux calculation for specific subsets of units. I think we could reasonably support flux density per pixel and flux density per area, but I think that things like flux density per beam or even worse, antenna temperature, will be trickier. So rather than require specific units, we could start with at least specific types of units. I'll try and work on this this afternoon and update this PR.

What is needed to implement levelprops/cprops? (I've never used these, so I'm not familiar with them)

— Reply to this email directly or view it on GitHubhttps://github.com/dendrograms/dendro-core/issues/44#issuecomment-20872020 .

astrofrog commented 10 years ago

A release candidate is available via GitHub releases:

https://github.com/dendrograms/astrodendro/releases/tag/0.1.0rc1

Please also check over the docs:

http://dendrograms.org/

to make sure some of the recent changes are there :)