search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Refactor I/O code #63

Closed astrofrog closed 11 years ago

astrofrog commented 11 years ago

This moves the automated format detection to astrodendro.io and also allows recognition via the file signature. The motivation here is that if we add data loaders, they can share the identification code with the dendrogram loaders/exporters.

astrofrog commented 11 years ago

@ChrisBeaumont - do you have any objections to this? This makes the I/O a little more like Astropy by having 'identifier' functions that can identify a file based on e.g. its signature if it already exists (rather than just based on the extension).

ChrisBeaumont commented 11 years ago

Aside from my comments, this looks good

astrofrog commented 11 years ago

I agree the namedtuple stuff looks nicer - can you check to make sure it's what you were suggesting?

ChrisBeaumont commented 11 years ago

Looks good to me!