Closed astrofrog closed 10 years ago
Good idea. There are a few definitions for area in common use -- one is just the area of the mask (or projected mask in PPV). The other uses sig_maj and sig_min, to give an intensity-weighted spatial dispersion. It's probably best to just pick one for now.
I was thinking more the actual area of the mask, which is the 'real' area of the structure. The area of the ellipse is easy enough to derive. Though we could have area_exact
and area_ellipse
or something like this?
@ChrisBeaumont - what do you think of the attached code? For area_exact
for the PPV statistic I was thinking of finding the projected pixel area if the structure is collapsed in the velocity direction. Does this make sense? If so I can add it.
+1. Projecting the PPV cube to compute area_exact sounds good -- Rahul Shetty (and others) have used this definition of area in papers.
Looks good, except for the note about the imprecise docstring
I clarified the docstring. I didn't include the equation because it won't be visible in the docs since this is a property (only the first sentence of text is shown).
Looks good (is the full docstring at least displayed by IPython?)
@ChrisBeaumont - yes, it should be actually - though in that case I would vote that we can include the equation as 'human-readable' rather than LaTeX since it will never be rendered in LaTeX.
Looks good to me
Should be straightforward - need to remember to get the units right if
spatial_scale
is available.