search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Should pixel statistics be quantities or floats #74

Closed astrofrog closed 10 years ago

astrofrog commented 11 years ago

For statistics which are e.g. angles, it makes sense to return Astropy Quantity objects. However, for statistics in pixel units, I wonder whether maybe we should return simple Python floats rather than Quantity objects with u.pix objects. Otherwise we end up with this kind of problem: #71 - we can still have the heading in the catalog table be set to pix automatically, which is what this was intended for.

ChrisBeaumont commented 11 years ago

I don't have a clear opinion on this. I guess I don't like adding an extra branch to handle whether or not something is a u.pix unit, but I haven't thought through all the implications of either choice. I agree that #71 looks rather ugly

astrofrog commented 11 years ago

Ok, now the code in #71 is less ugly, maybe this isn't so big a deal. I'll leave it open for a little in case I come across any other examples.

astrofrog commented 10 years ago

Decision: let's leave pixel values being returned as quantities, but improve documentation