search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Collection of pruning functions #78

Closed ChrisBeaumont closed 11 years ago

ChrisBeaumont commented 11 years ago

This addresses issue #76

astrofrog commented 11 years ago

@ChrisBeaumont - looks great! It looks like it fails with Numpy 1.5.1 though - would it be easy to fix?

ChrisBeaumont commented 11 years ago

Yeah, it should be. I'll work around the missing function

astrofrog commented 11 years ago

Thanks! Could you also expand the docs a little to show an example of chaining the functions?

astrofrog commented 11 years ago

@ChrisBeaumont - just a reminder about this pull request. I think it would be nice to have a release soon-ish as I've had a few people asking me about it.

ChrisBeaumont commented 11 years ago

Thanks for the ping. Ill wrap this up on monday On Aug 17, 2013 2:56 PM, "Thomas Robitaille" notifications@github.com wrote:

@ChrisBeaumont https://github.com/ChrisBeaumont - just a reminder about this pull request. I think it would be nice to have a release soon-ish as I've had a few people asking me about it.

— Reply to this email directly or view it on GitHubhttps://github.com/dendrograms/dendro-core/pull/78#issuecomment-22817552 .

ChrisBeaumont commented 11 years ago

Ok, this seems to be passing now. I also expanded the docs a bit -- is this what you had in mind?

astrofrog commented 11 years ago

Looks good - feel free to merge!