search

dendrograms / astrodendro

Generate a dendrogram from a dataset
https://dendrograms.readthedocs.io/
Other
37 stars 38 forks source link

Try and make it clearer that representation on front page uses isocontours #87

Closed astrofrog closed 10 years ago

astrofrog commented 10 years ago

Addresses #23

astrofrog commented 10 years ago

@ChrisBeaumont - what about this? Do you think it's clearer, or actually makes things more confusing?

astrofrog commented 10 years ago

(slightly updated today)

ChrisBeaumont commented 10 years ago

I'm ambivalent about whether the text is a helpful clarification, or whether it brings attention to a subtler conceptual issue that many readers wouldn't otherwise notice or care about.

If there's a way that we can communicate this with the figure only (i.e. no extra text), I'd be in favor of that. However, this isn't a major objection, so I'm also fine with merging this for now and revisiting in the future.

astrofrog commented 10 years ago

If I just changed the figure (as it is in this PR) and not the text, would that be sufficient in your opinion? I also don't find this particularly helpful (the text I mean).

ChrisBeaumont commented 10 years ago

Yes perhaps. What about increasing the stroke weight for the contour that corresponds to each dotted line? Something like this

image

In other news, I freaking love the Paper app

astrofrog commented 10 years ago

Nice! I really like the paper app too, especially with the stylus! WIll try and do what you suggest

astrofrog commented 10 years ago

@ChrisBeaumont - do you mean like one of these?

schematic_tree_nolines

schematic_tree

ChrisBeaumont commented 10 years ago

Yes -- I love the one on the top, and I think it's clear what's going on without the dashed lines. If you like the dashed lines, I'm fine with that too

I am +1 on using the top image, removing the text changes in index.rst, and merging this

astrofrog commented 10 years ago

@ChrisBeaumont ok, great! Merging now :)