dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.68k stars 252 forks source link

Automatic title extraction doesn't work in cross-vault links without `dendron//` prefix #1429

Open aleksey-rowan opened 3 years ago

aleksey-rowan commented 3 years ago

Please select the area your Bug applys to. (Multiple selections are Possible)

Describe the bug

A note title is not shown (given useNoteTitleForLink is set to true) for naked cross-vault links in preview without the dendron// prefix. These links also can't be clicked in the preview.

[[foo.bar]]

Will be rendered as simply foo.bar.

The full link ([[dendron://vault/foo.bar]]) does render correctly as Foo Bar.

To Reproduce

Steps to reproduce the behavior:

  1. Add a link to a note from a different vault.
  2. Open V2 preview
  3. See the link rendered as note's filename, not its title

Expected behavior

The useNoteTitleForLink setting should be respected regardless of the dendron// prefix.

Desktop (please complete the following information)

Additional context

This could be related to https://github.com/dendronhq/dendron/issues/1213.

hikchoi commented 3 years ago

Thank you for the report. Like the document says: Currently, useNoteTitleForLink is not fully supported in a multi-vault environment. We'll track this in our backlog and see what we can do 🙂

aleksey-rowan commented 3 years ago

Like the document says: Currently,useNoteTitleForLink is not fully supported in a multi-vault environment.

Ah, my bad, I've missed that.

aleksey-rowan commented 3 years ago

Clicking cross-vault links without the dendron// prefix in preview doesn't work (nothing happens when you click) and it doesn't seem to be related to the useNoteTitleForLink setting. Is this also a known issue or a separate bug?