Only split editor once on `multiSelect` + `split`

aleksey-rowan commented 2 years ago

Please Select if your Request is Either something new or an Enhancement

[x] Enhancement of an existing Feature.
[ ] Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

[ ] Onboard. Initial vault setup and import/export pods
[x] Create. Note creation, lookup, snippets and templates
[x] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[ ] Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe

When using multiSelect and split modifiers together during a lookup, Dendron splits the editor as many times as the notes you've selected and you end up with multiple editor groups.

Describe the solution you'd like

I think it will be more useful to only split the editor once when using a combination of multiSelect and split modifiers and open all the selected notes in a single editor group.

Describe alternatives you've considered

There are not alternatives I can think of.

Additional context

It might be possible that splitting editor multiple times is useful sometimes, but I don't know if that warrants having two modifiers: splitOnce and splitMany.

kevinslin commented 2 years ago

What would be the expected behavior for you? Would all notes open up in the second split or would it be configurable between the first and the other? This function was originally created for the single select case.

kevinslin commented 2 years ago

So this is an issue with VSCode - it has its own function for highlighting which currently we are unable to override. Unfortunately there's not much we can do about it at this point besides make sure that we can support it on the nextjs client. looping in @nickolay-kondratyev in case he has more to add

aleksey-rowan commented 2 years ago

What would be the expected behavior for you? Would all notes open up in the second split or would it be configurable between the first and the other? This function was originally created for the single select case.

For me personally, all notes opening in the second split is what I would expect. Adding a configurable option is always nice in case someone wants it the other way, but this always adds complexity.

So this is an issue with VSCode - it has its own function for highlighting which currently we are unable to override. Unfortunately there's not much we can do about it at this point besides make sure that we can support it on the nextjs client. looping in @nickolay-kondratyev in case he has more to add

I think this comment is related to https://github.com/dendronhq/dendron/issues/1530 instead.

dendronhq / dendron