Dendron starts in non-Dendron workspaces and is slow to start anyway

lnicola commented 2 years ago

Please select the area your Bug applys to.

[ ] Onboard. Initial vault setup and import/export pods
[ ] Create. Note creation, lookup, snippets and templates
[ ] Retrieve. Backlinks, references, graph view
[ ] Structure. Refactoring, multi-vault and schemas
[ ] Publish. Sharing your repo with the world
[x] Misc (Choose this if your not sure)

Describe the bug

The Code extension slows down the editor startup.

To Reproduce

Steps to reproduce the behavior:

Open a project that's not a Dendron workspace
Open the extension list
Note how Dendron takes a long time to start

Expected behavior

Dendron only starts in Dendron workspaces
It would be nice if it started faster even in those, but whatever

The other annoying thing is that Dendron brings two "Show Preview" commands that conflict with other commands in popular extensions. Sometimes I'm editing AsciiDoc or another Markdown file, and I run the Dendron command by mistake.

Screenshots

Here it took 256 ms on a reasonably fast computer:

Desktop (please complete the following information)

OS: Linux
Browser: N/A
Version: 0.63

Additional context

Since Dendron is already split between multiple extensions, my suggestion is to split the workspace initialization into another extension. This way, "Initialize workspace" would always be available, but the main extension could have an "workspaceContains:dendron.yml" activation event instead of "*".

Dendron Log file

N/A

kevinslin commented 2 years ago

For Dendron taking a long time to start on a non-dendron workspace, will take a followup to look into that. Our work Q for next week is already full so this will be the following week. For Show Preview, we can add a context clause to have it be available when working inside a Dendron workspace. Mind splitting that off in a separate feature request?

lnicola commented 2 years ago

Filed #1545.

Don't worry about taking longer to solve it. It's open-source (and free) software. If it gets fixed in the next six months or so, I'm happy :-).

kevinslin commented 2 years ago

This should be fixed in v69. Can you let us know if this is still an issue?

lnicola commented 2 years ago

Maybe I'm missing something, but it still gets activated in a non-Dendron directory.

kevinslin commented 2 years ago

ah - you're right. i was mixing this up with the preview issue. will keep this open

dendronhq / dendron