dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.69k stars 253 forks source link

Using "move header" on same note twice will cause the whole note to be copied on the second time #1762

Open simkimsia opened 2 years ago

simkimsia commented 2 years ago

Please select the area your bug applies to. (Multiple selections are Possible)

Describe the bug

Better if i show you video

Desktop (please complete the following information)

Version: 1.62.3 Commit: ccbaa2d27e38e5afa3e5c21c1c7bef4657064247 Date: 2021-11-17T07:59:13.865Z (3 days ago) Electron: 13.5.2 Chrome: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Darwin x64 20.6.0 Dendron: v0.69.1

Dendron Log file

{"level":30,"time":1637473933747,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"Logger:configure","msg":"exit","logLevel":"info"} {"level":30,"time":1637473933873,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"_activate","stage":"prod","isDebug":false,"logLevel":"info","logPath":"/Users/kim/Library/Application Support/Code/logs/20211121T123452/exthost3/dendron.dendron","extensionPath":"/Users/kim/.vscode/extensions/dendron.dendron-0.69.1","extensionUri":"/Users/kim/.vscode/extensions/dendron.dendron-0.69.1","workspaceFile":"/Users/kim/Dendron/dendron.code-workspace","workspaceFolders":["/Users/kim/Dendron/vault"]} {"level":30,"time":1637473933874,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"No cache path for Segment specified. Failed event uploads will not be retried."} {"level":30,"time":1637473933874,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"user telemetry setting: enabled by config"} {"level":30,"time":1637473933875,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"telemetry initializing"} {"level":30,"time":1637473933875,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"using existing id"} {"level":30,"time":1637473933889,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"DendronExtension","msg":"initialized"} {"level":30,"time":1637473933972,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"_activate","msg":"initializeWorkspace","wsType":"CODE","currentVersion":"0.69.1","previousWorkspaceVersion":"0.69.1","previousGlobalVersion":"0.69.1","extensionInstallStatus":"NO_CHANGE"} {"level":30,"time":1637473934004,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"No cache path for Segment specified. Failed event uploads will not be retried."} {"level":30,"time":1637473934004,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"user telemetry setting: enabled by config"} {"level":30,"time":1637473934004,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"telemetry initializing"} {"level":30,"time":1637473934004,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"using existing id"} {"level":30,"time":1637473934005,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","msg":"Telemetry is disabled? false"} {"level":30,"time":1637473934005,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","msg":"Segment Residual Cache Path is at undefined"} {"level":30,"time":1637473934366,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"dendron.dev.openLogs:run","msg":"pre-execute"} {"level":30,"time":1637473934366,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"execute","opts":{}} {"level":30,"time":1637473934502,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"user telemetry setting: enabled by config"} {"level":30,"time":1637473934502,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"telemetry initializing"} {"level":30,"time":1637473934502,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"using existing id"} {"level":30,"time":1637473934502,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","msg":"Telemetry is disabled? false"} {"level":30,"time":1637473934503,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","msg":"Segment Residual Cache Path is at /Users/kim/Library/Application Support/Code/User/globalStorage/dendron.dendron/segmentresidualcache.log"} {"level":30,"time":1637473934503,"pid":44024,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"Attempting to flush residual segment data from file."} {"level":30,"time":1637473934547,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"_activate","workspaceInstallStatus":"NO_CHANGE","currentVersion":"0.69.1","previousWorkspaceVersion":"0.69.1","previousGlobalVersion":"0.69.1","platform":"darwin","extensions":[{"id":"dendron.dendron-paste-image","version":"1.1.0","active":false},{"id":"dendron.dendron-markdown-shortcuts","version":"0.12.1","active":true},{"id":"redhat.vscode-yaml","version":"1.2.0","active":false}],"vaults":[{"fsPath":"vault"}]} {"level":30,"time":1637473934552,"pid":44024,"hostname":"kimsia-mbp-2014","name":"execServer","state":"enter"} {"level":30,"time":1637473934560,"pid":44024,"hostname":"kimsia-mbp-2014","name":"execServer","state":"post:exec.node"} {"level":30,"time":1637473934917,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","msg":"Segment Residual Cache flush attempted. {\"successCount\":0,\"nonRetryableErrorCount\":0,\"retryableErrorCount\":0}"} {"level":30,"time":1637473935221,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"dendron.dev.openLogs:run","msg":"post-execute"} {"level":30,"time":1637473939136,"pid":44033,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"No cache path for Segment specified. Failed event uploads will not be retried."} {"level":30,"time":1637473939137,"pid":44033,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"user telemetry setting: enabled by config"} {"level":30,"time":1637473939137,"pid":44033,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"telemetry initializing"} {"level":30,"time":1637473939137,"pid":44033,"hostname":"kimsia-mbp-2014","name":"SegmentClient","msg":"using existing id"} {"level":30,"time":1637473939327,"pid":44024,"hostname":"kimsia-mbp-2014","name":"execServer","state":"message","message":"59459"} {"level":30,"time":1637473939339,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"WSUtils.handleServerProcess","msg":"subprocess running","pid":44033} {"level":30,"time":1637473939339,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"_activate","msg":"post-start-server","port":59459,"durationStartServer":5366} {"level":30,"time":1637473939343,"pid":44024,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"FileStorageV2","wsRoot":"/Users/kim/Dendron","vaults":[{"fsPath":"vault"}],"level":"info"} {"level":30,"time":1637473939352,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"dendron.reloadIndex:run","msg":"pre-execute"} {"level":30,"time":1637473939352,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"ReloadIndex.execute","msg":"enter"} {"level":30,"time":1637473942091,"pid":44033,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"parsingSchemas","fname":"daily","root":{"fsPath":"vault"}} {"level":30,"time":1637473942094,"pid":44033,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"parsingSchemas","fname":"framework","root":{"fsPath":"vault"},"imports":[]} {"level":30,"time":1637473942100,"pid":44033,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"parsingSchemas","fname":"lang","root":{"fsPath":"vault"}} {"level":30,"time":1637473942103,"pid":44033,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"parsingSchemas","fname":"pro","root":{"fsPath":"vault"}} {"level":30,"time":1637473942259,"pid":44033,"hostname":"kimsia-mbp-2014","name":"logger","ctx":"parsingSchemas","fname":"weekly","root":{"fsPath":"vault"}} {"level":30,"time":1637473944426,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944649,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944656,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944662,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944824,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944866,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473944934,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":1,"noteRefsLength":0,"wikiLinksLength":1} {"level":30,"time":1637473944965,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":3,"noteRefsLength":0,"wikiLinksLength":3} {"level":30,"time":1637473945087,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473945225,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":0,"noteRefsLength":0,"wikiLinksLength":0} {"level":30,"time":1637473945468,"pid":44033,"hostname":"kimsia-mbp-2014","name":"LinkUtils.getLinks","ctx":"getLinks","dlinksLength":7,"noteRefsLength":0,"wikiLinksLength":7} {"level":30,"time":1637473945965,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"ReloadIndex.execute","durationEngineInit":4276} {"level":30,"time":1637473945965,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"ReloadIndex.execute","msg":"exit"} {"level":30,"time":1637473945965,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"dendron.reloadIndex:run","msg":"post-execute"} {"level":30,"time":1637473945966,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"reloadWorkspace","msg":"post-ws.reloadWorkspace"} {"level":30,"time":1637473945967,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"reloadWorkspace","msg":"exit"} {"level":30,"time":1637473945967,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"postReloadWorkspace","msg":"same wsVersion"} {"level":30,"time":1637473945967,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"postReloadWorkspace","msg":"exit"} {"level":30,"time":1637473945968,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"TreeView:getChildren","msg":"reconstructing tree: enter"} {"level":30,"time":1637473946167,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"setupViews","msg":"init:treeViewV2"} {"level":30,"time":1637473946170,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"setupBacklinkTreeView","msg":"init:backlinks"} {"level":30,"time":1637473946178,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"activateWorkspace","stage":"prod","msg":"enter"} {"level":30,"time":1637473946197,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"toggleViews","msg":"views enabled: true"} {"level":30,"time":1637473946198,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"_activate","msg":"fin startClient","durationReloadWorkspace":12200} {"level":30,"time":1637473946199,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"showWelcomeOrWhatsNew","version":"0.69.1","previousExtensionVersion":"0.69.1"} {"level":30,"time":1637473946293,"pid":44024,"hostname":"kimsia-mbp-2014","name":"dendron","ctx":"TreeView:getChildren","msg":"reconstructing tree: exit"}

hikchoi commented 2 years ago

Thank you for the report.

This actually isn't a problem specific to selecting the header when it's the first section, but rather our file watcher not catching that the file has changed after the first move header command.

If you use the move header command on the same note twice, you will see that no matter what header you have selected the behavior will be the same (moves the entire note body to the destination).

The interim solution is to reload before the subsequent move header usages, but that is not an ideal user experience. I'll take a look at this and let you know once we can get a fix in.

simkimsia commented 2 years ago

reload before the subsequent move header usages

reload as in save the note changes? or reload window?

hikchoi commented 2 years ago

reload before the subsequent move header usages

reload as in save the note changes? or reload window?

As in Reload Index or Reload Window

simkimsia commented 2 years ago

As in Reload Index or Reload Window

Understood. I have no further questions. Guess my title is mistaken. I will change it. Feel free to close this if this isn't a bug

hikchoi commented 2 years ago

This definitely is a bug. I'll be working on it when I get the chance. Thank you for changing the title :)