search

dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.72k stars 255 forks source link

Tree View is Empty #2534

Closed jgmpjgmp closed 2 years ago

jgmpjgmp commented 2 years ago

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

Describe the bug

My Tree View section is completely empty. After reading other issues, I searched for notes with double dots in the title (none) and for reloaded index. without any change. Problem has actually affected me for several months.

I am also seeing the "Cannot read property 'title' of Undefined error (https://github.com/dendronhq/dendron/issues/2451)

To Reproduce

Sorry - unknown

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

Additional context

Add any other context about the problem here.

Dendron Log file

Please attach the output of > Dev:Dendron: Open Logs here Log.txt

Ding-Fan commented 2 years ago

If you have old daily.journal.xxx.md files, move them out of this vault ( for example, move to a temp folder at your Desktop ) and restart VSCode. See if this helps.

jgmpjgmp commented 2 years ago

No journal files (for better or for worse)

SeriousBug commented 2 years ago

This will likely be solved with #2528.

jonathanyeung commented 2 years ago

Hi @jgmpjgmp - are you using Tree View V1 or V2?

Tree View V1 is the default setting, but if your dendron.yml file (command to open is Dendron: Configure (yaml) ) has this in it, then it's V2:

dev:
    enableWebUI: true
jgmpjgmp commented 2 years ago

It was V1. Adding the enableWebUI: true fixed it -- showing the treeview. Thanks!

jonathanyeung commented 2 years ago

Glad that V2 is working for you - however, let's leave this issue open as the fix that @SeriousBug mentioned above only applies to V1, and V1 should be working as well.

SeriousBug commented 2 years ago

@jonathanyeung On that matter, do you know when the V1 tree view will be dropped (or V2 will become default)? Are there missing features we're waiting on?

jonathanyeung commented 2 years ago

@jonathanyeung On that matter, do you know when the V1 tree view will be dropped (or V2 will become default)? Are there missing features we're waiting on?

I don't think we have any missing features (although I can think of some reasons why users may prefer v1 over v2), but we also haven't discussed a migration plan yet. I suspect that the vast majority of our users are using v1 and not v2.

jgmpjgmp commented 2 years ago

Unfortunately, this fix stopped working. I migrated to a new machine (installed VSCode on the new machine, then Dendron, then copied my MD file tree across). The Tree View is now empty (but no error) when enableWebUI: true and empty with “Cannot read properties of undefined (reading ‘fname’)” error when enableWebUI: false.

From: jonathanyeung @.> Sent: Monday, March 7, 2022 10:40 PM To: dendronhq/dendron @.> Cc: Pennebaker, John (SV) @.>; Mention @.> Subject: Re: [dendronhq/dendron] Tree View is Empty (Issue #2534)

@jonathanyeunghttps://github.com/jonathanyeung On that matter, do you know when the V1 tree view will be dropped (or V2 will become default)? Are there missing features we're waiting on?

I don't think we have any missing features (although I can think of some reasons why users may prefer v1 over v2), but we also haven't discussed a migration plan yet. I suspect that the vast majority of our users are using v1 and not v2.

— Reply to this email directly, view it on GitHubhttps://github.com/dendronhq/dendron/issues/2534#issuecomment-1061458726, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYCHVBA4IK4VASA62SGPT7LU63Y4ZANCNFSM5QD6FUOQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

This email may contain material that is confidential, privileged and/or attorney work product for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies including any attachments.

Latham & Watkins LLP or any of its affiliates may monitor electronic communications sent or received by our networks in order to protect our business and verify compliance with our policies and relevant legal requirements. Any personal information contained or referred to within this electronic communication will be processed in accordance with the firm's privacy notices and Global Privacy Standards available at www.lw.com.

jonathanyeung commented 2 years ago

@jgmpjgmp - appreciate your patience here. We've actually changed our decision and decide to actually stick with V1 and deprecate V2 of tree view.

On that though - we're actively investigating a few issues right now related to this and testing a few fixes that we're targeting in the next 1-2 releases. Let's loop back when they fixes are out and see.

jgmpjgmp commented 2 years ago

This was resolved by upgrading to 0.95.1 !

SeriousBug commented 2 years ago

Glad it works!