Preview shows "Start anchor ... not found" when linking notes.

jhoan2 commented 2 years ago

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup. Dendron's Lookup Command
[ X ] Views. Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema. Dendron Schemas
[ ] Pod. Data import from / export to Dendron
[ ] Publish. External Site Publish
[ ] Markdown. Markdown features, such as syntax support and features

Describe the bug

Preview shows "Start anchor ^l8snrvxr0ub2 not found."

To Reproduce

Steps to reproduce the behavior:

Go to the note
Highlight the portion
ctrl + shift r
Go to another note and paste the link
See error in preview pane.

Expected behavior

Expected for the preview to show the portion between the two block anchors.

Screenshots

Desktop (please complete the following information)

OS: windows
Browser (if with published websites; include version): [e.g. chrome, safari]
Versions (all that apply to bug):
- Dendron Extension: 0.85.0
- VS Code version: 1.65.2
- Dendron CLI:

Additional context

Add any other context about the problem here.

Dendron Log file

dendron.log

Please attach the output of > Dev:Dendron: Open Logs here

hikchoi commented 2 years ago

Just for reference to whoever picks this up in the future:

preview is working as intended, but since the four lines here are one block of text in the syntax tree, copyNoteRef should only insert the end anchor in this case.

I also notice that when a codeblock is selected, the inserted anchors will not render properly in preview out of the box.

there may be more edge cases of faulty anchor insertions with multiline selections but I have not found anything else yet. Will report here if I find anything else.

jhoan2 commented 2 years ago

The command shouldn't insert anchors if the selection is inside a codeblock. (This is a bug with anchor insertion rather than preview rendering)

Harshita-mindfire commented 2 years ago

Thanks @jhoan2 for reporting the bug. Tracking it internally with: [[Preview Shows Start Anchor Not Found When Linking Notes|dendron://private/task.2022.03.15.preview-shows-start-anchor--not-found-when-linking-notes]]

dendronhq / dendron