Open ttytm opened 2 years ago
kevinslin
commented
2 years ago this is definitely something we would like to support - just haven't had the bandwidth to. if you would like to contribute a pr, that would be super and be happy to point out relevant parts of the code to get started (code setup docs here)
aleksey-rowan
commented
2 years ago Hey, @tobealive, this looks fantastic! Non-adaptive themes is an eye-sore for sure.
Linking some related items here for reference:
ttytm
commented
2 years ago Hey,
Thanks for your replies!
Nice, I'll do my best on this next week. Maybe split it into fixes by properties. Then I'd start with the backgrounds because I think this is the easiest and most dominant (also light themes use the dark/brownish background *edit: actually not the case. Just needed to reload the window after switching themes, and they used a white background). Scrollbars and stuff will be a bit harder, which can be done separately.
It would also be great if the scrollbars respected the width/height configured in the settings. I didn't look into this yet but, maybe someone knows if vscodes api makes those values accessible.
ttytm
commented
2 years ago Hey hello, please forgive that this takes so long. My job situation changed, and I didn't manage to work on the issue I opened until today.
For now, I created a repo that applies a themes colors in the Previews for the graph and Markdown. Also for fonts and scrollbars. But current it's post installing the dendron plugin. Unfortunately I hadn't had the chance yet to implement and test it on a core level that it's applied dynamically during the installation of the extension. And in the next weeks I'll barely find the time to do so :/.
Following the link to the repo It's split into commits that target the coloration of the background, font colors and scrollbars. https://github.com/tobealive/dendron-adopt-theme-styles/
I am hoping that someone will come along to help out with this. Maybe seeing those changes in the repo makes it easier to hunt them down and integrate them on a core level. A theme I found fitting for testing dendron's behavior on dark / light variants was e.g., Eva.
Sorry again for announcing this and coming back to it not having it already finished. Unfortunately the situation is too busy for me currently to make it a priority.
aleksey-rowan
commented
2 years ago update: 0.97 has shipped with partial theme support for note preview.
Hello,
before I finish the work to do a PR I wanted to ask if it is even a thing that's wanted.
One little flaw I experienced while using dendron is its non-adaptable stylesheet to themes. Working as a designer, I came to learn that this is called "knows it better"-design. E.g., backgrounds for the preview, note graph, calendar etc. have it's fixed values.
This is how they should(?) behave
The next thing that is visible is that the scrollbars are doing their own thing with the given stylesheet as well.
Which could be as smooth as this
There are some other places i've seen this happens At lease the background of the window splits that are so dominant on the screenshots, the fix would be as simple as setting it to transparent.
I know that I'm pretty picky about such things and would understand if there are other things that are prioritized. In any case I'm looking forward to further development. Thanks for the work that far!