dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.65k stars 252 forks source link

Definitions of abbreviations are visible in Dendron preview #3789

Open re-pesk opened 1 year ago

re-pesk commented 1 year ago

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

Describe the bug

Abbreviation definitions are visible in the markdown preview.

To Reproduce

Steps to reproduce the behavior:

  1. Go to markdown file
  2. Create abbreviations
    *[CTSS]: Compatible Time-Sharing System, 1961  
    *[Unix]: Unix, 1969  
  3. Click on 'Dendron: Toggle preview (Ctrl+K V)'
  4. See CTSSUnix in preview tab.

Expected behavior

Text CTSSUnix should not be visible.

Screenshots

Abbreviations_error

Desktop (please complete the following information)

Dendron Log file

dendron.log

jonathanyeung commented 1 year ago

@Dendron Dev for anyone investigating this - this functionality is handled by this remark plugin: https://www.npmjs.com/package/remark-abbr

Seems like the parsing output of this plugin is colliding with some other plugin (perhaps our own) that's causing the abbreviation definitions to still get rendered.