Graph view showing notes connected to filtered out notes

wiktoriavh commented 1 year ago

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup. Dendron's Lookup Command
[x] Views. Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema. Dendron Schemas
[ ] Pod. Data import from / export to Dendron
[ ] Publish. External Site Publish
[ ] Markdown. Markdown features, such as syntax support and features

Describe the bug

I have a note that links to a User Note, which links to several other notes. When I activate Backlinks, I see all of those connections. But then I choose to filter out "user" notes. The user note than vanishes, but the connections to the user note still applies. I would like for when it is connected directly to the user note, or the note i am filtering out, it should not be shown. Especially in the Local Graph View.

The image shows a cluster of notes that link to a user note, which is linked to the note in the bottom left corner.

To Reproduce

Steps to reproduce the behavior:

Create user note
create anote note that links to the user note (@theName)
create yet another note that links to the user note, but not directly to the previous note
look at the locale graph view and filter out user
see something similar like the screenshot above

Expected behavior

To not show notes that are connected to my filtered out notes.

Screenshots

See image above.

Desktop (please complete the following information)

OS: macOS v 12.6.1
Browser (if with published websites; include version): no
Versions (all that apply to bug):
- Dendron Extension: 0.118.0
- VS Code version: 1.73.1 (Universal)
- Dendron CLI: i don't know where to check

Additional context

Add any other context about the problem here.

Dendron Log file

Please attach the output of > Dendron:Dev: Open Logs here

Harshita-mindfire commented 1 year ago

Thanks for reporting the issue @Braweria. Followup question: What is the depth set for your graph view?

Let me know if I reproed your issue correctly in this video or if is there something I'm missing. https://www.loom.com/share/86077ecc827442648c2b995cda9bb590

wiktoriavh commented 1 year ago

Hi @Harshita-mindfire . Your test case is exactly what I am talking about, I have also set it to 2.

I have just tried setting it back and forth between 1, 2 and 3 and it is the same issue. The graph view also goes quite crazy because of all those nodes there, after a second or so it calms down and stays put. It doesn't go crazy, if I don't filter out the note it is connected to.

Harshita-mindfire commented 1 year ago

got it. So presently, the graph only hides the links to the entries added in blocklist and does not re-render the entire graph. This did make sense back when the depth was not configurable and was always set to 1. I understand your issue and will update here when we have a fix for this edge case.

dendronhq / dendron