Dendron preview theme 'light' does not render table borders if VSCode theme is 'dark' - Githubissues

dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!

https://wiki.dendron.so

Apache License 2.0

6.53k stars 247 forks source link

Dendron preview theme 'light' does not render table borders if VSCode theme is 'dark' #3913

Open astdt opened 1 year ago

astdt commented 1 year ago

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup. Dendron's Lookup Command
[x] Views. Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema. Dendron Schemas
[ ] Pod. Data import from / export to Dendron
[ ] Publish. External Site Publish
[ ] Markdown. Markdown features, such as syntax support and features

Describe the bug

Setting preview -> theme property to "light" whilst having a dark VSCode theme does not render table borders.

To Reproduce

In VScode, set "workbench.colorTheme" to any dark theme.
In dendron.yml, set "theme: light" for preview setting.
Enable dendron preview for any .md file that renders a table.
Observe the bug. 4b. Ctrl + Shift + P -> Toggle between Light/Dark themes and observe the bug corrected whilst switching to light theme.

Expected behavior

Table's CSS renders properly.

Screenshots

Desktop (please complete the following information)

OS: Windows
Versions (all that apply to bug):
- Dendron Extension: v0.119.0
- VS Code version: 1.75.1
- Dendron CLI: N/A

Additional context

Dendron Log file