search

dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.52k stars 247 forks source link

This keybinding for the `ctrl-<enter>` needs an updated when statement #3966

Open raven42 opened 7 months ago

raven42 commented 7 months ago

The when statement for the Go to Note (ctrl-) needs to be updated. Currently it will trigger when in any editor window regardless if the open file is even a markdown file. At a minimum this when statement should be updated as follows:

"when": "editorFocus && editorLandId == 'markdown'"

If there is another way to tell if the active editor is in a dendron owned window, that would be even better.

https://github.com/dendronhq/dendron/blob/be2bd92551faddffe2e3937b6399e7e5767fe37c/packages/plugin-core/package.json#L1353

jorwoods commented 6 months ago

This is critical. This seems to take precedence and break other plugins, rendering VSCode useless for other parts of a normal workflow.