dendronhq / dendron

The personal knowledge management (PKM) tool that grows as you do!
https://wiki.dendron.so
Apache License 2.0
6.68k stars 252 forks source link

Obfuscation of information that gets saved in the logs. #671

Open ghost opened 3 years ago

ghost commented 3 years ago

Please Select if your Request is Either something new or an Enhancement

Please select the area your request applys to. (Multiple selections are Possible)

Is your feature request related to a problem? Please describe

Today users on the discord mentioned some privacy concerns, about the information that is contained in the logs.

Describe the solution you'd like

  1. That the logs that get written have the hostname entry removed or obfuscated.
    • I don't see why this information is needed for debugging purposes.
  2. That the Filenames get Obfuscated.
    • by replacing each filename segment with a * that way there is still some value in them but we are not saving maybe sensitive information at locations that may or may not be outside of the scope of Control from the user.
  3. Additionally it should be further noted, that we only save data we truly need in these logs.
    • and should possibly Investigate which information we truly need.

Additional context

Beginning of the Discord discussion. https://discord.com/channels/717965437182410783/717965437182410786/836625205291646986

Bassmann commented 3 years ago

I'd like to see obfuscation of the username too. It's typically part of the file path. I routinely replace it before sending logs

ognjenio commented 3 years ago

Also the vault path and the log path

SirBillyMays commented 3 years ago

Some of us who use git in certain corporate contexts have to use PAT's with (for example) github. I'd appreciate it if the log export could obfuscate the token, or even the full git url. https://<personal_access_token>@gitrepo.tld -> https://PAT@gitrepo.tld, for instance.