search

denehyg / reveal.js-menu

Slide out menu for reveal.js
https://denehyg.github.io/reveal.js-menu
MIT License
281 stars 76 forks source link

'm' keyboard shortcut does not work when jump.js installed #33

Closed jcamp closed 6 years ago

jcamp commented 7 years ago

As heading really.

When you have jump.js installed (allows you to enter a slide number and hit return to go to that slide) and the menu all still is good, but the 'm' keyboard shortcut does not work.

Could be an issue with jump.js or the menu I suppose, but worth a look to see an easy fix...

denehyg commented 7 years ago

I can't reproduce this under Chrome, Firefox or Safari under macOS. If there is an issue I suspect it might be with jump.js as it overrides document.onkeypress directly rather than adding an event listener, but I'm not sure.

jcamp commented 7 years ago

Thanks. Not sure which is more useful... m or typing in the number of the slide and hitting enter. Probably m keyboard so will not use jump.js for the moment. Cheers

denehyg commented 6 years ago

I going to close this one. If you consider this to still be an issue feel free to reopen it.