Support for Font Awesome 5 SVG with JS framework

denehyg / reveal.js-menu

Slide out menu for reveal.js

https://denehyg.github.io/reveal.js-menu

MIT License

281 stars 76 forks source link

Support for Font Awesome 5 SVG with JS framework #54

Closed gcalmettes closed 6 years ago

gcalmettes commented 6 years ago

Font Awesome 5 introduced a new SVG with Javascript framework. When this framework is used, the <i> tags are replaced with <svg> tags to render the icons.

The current css styles provided for this plugins are not applied when the SVG with JS framework is used since they are targeted to <i> tags only. I opened a PR to extend the CSS styles to SVG.

Imgur

denehyg commented 6 years ago

Thanks for this. I've merged the PR and also handled sizing for icons used in the toolbar. Released under v1.1.3.

gcalmettes commented 6 years ago

Thanks a lot! I'll update my dependencies with the new version!