search

denehyg / reveal.js-menu

Slide out menu for reveal.js
https://denehyg.github.io/reveal.js-menu
MIT License
281 stars 76 forks source link

update options doc #57

Closed clayt85 closed 5 years ago

clayt85 commented 5 years ago

Two things I have noticed:

The "themes" configuration option is true by default (not false, as indicated in the docs).

Also, there is a "transitions" configuration option that functions just like "themes", but is not documented.

denehyg commented 5 years ago

Which version of the plugin are you using? Note that the defaults for themes and transitions options changed at v1.0.0. They used to be enabled by default but now they need to be explicitly enabled in the options. If you are using a plugin version numbe earlier than 1.0.0 then the docs on github will not match.

clayt85 commented 5 years ago

It appears that you have a point :-) My apologies.

FWIW, I am using the reveal.js-plugins library, which includes reveal.js-menu as a submodule. That submodule is currently pointing to commit 97d8561 (tag: 0.6.0).

So the "wrong defaults" comment should be ignored. But it does seem like "missing 'transitions' doc" is still valid?

denehyg commented 5 years ago

Not sure what you mean. The transitions option is documented directly under the theme option. If you're looking for details for v0.6.0 the only option was to show or hide the transition menu, there was ability to specify anything more.

clayt85 commented 5 years ago

Indeed. I can't even find what I was looking at now... Thanks for taking the time to respond.