search

denesb / xfce4-i3-workspaces-plugin

A workspaces plugin for xfce4 and the i3 window manager.
GNU General Public License v3.0
122 stars 19 forks source link

Crashes if a not-focused workspace is emptied #3

Closed xuhdev closed 9 years ago

xuhdev commented 9 years ago

On this line, it assumes the emptied workspace is always the last focused one. It's not necessarily true: a window can be killed in another workspace to empty it, e.g. you can use the Pidgin tray icon to terminate pidgin in a different workspace.

denesb commented 9 years ago

I was able to trigger multiple crashes yesterday while "stresstesting" the plugin. It always crashed when a workspace was emptied, so this could be the problem. I must find another way then to tell which workspace has to be destroyed.

On Mon, Dec 8, 2014 at 11:11 PM, Hong Xu notifications@github.com wrote:

On this line https://github.com/denesb/xfce4-i3-workspaces-plugin/blob/master/panel-plugin/i3wm-delegate.c#L245, it assumes the emptied workspace is always the last focused one. It's not necessarily true: a window can be killed in another workspace to empty it, e.g. you can use the Pidgin tray icon to terminate pidgin in a different workspace.

— Reply to this email directly or view it on GitHub https://github.com/denesb/xfce4-i3-workspaces-plugin/issues/3.

Dénes Botond dns.botond@gmail.com

xuhdev commented 9 years ago

I opened a i3 ticket to solve this

denesb commented 9 years ago

I solved this in 1.0.0 by re-requesting the workspace list on empty/init events.