search

dengste / org-caldav

Caldav sync for Emacs orgmode
GNU General Public License v3.0
723 stars 105 forks source link

Location property synched to remote calendar, but not backwards #123

Open rgemulla opened 7 years ago

rgemulla commented 7 years ago

When an org-entry has a LOCATION property, org-caldav syncs the the entry correctly to the remote calendar (both creation, changes, and deletion of the location).

The other way around does not work, however: changes of the location in the calendar are not picked up at all by org-caldav.

grauschnabel commented 7 years ago

Yes, that's how it's written in the readme.

rgemulla commented 7 years ago

I understood the README as follows: at the time the README was written, org-icalendar seemed to have ignored the location property. Now it extracts it correctly (it's in the ics file and thus will be synched). Just not backwards.

grauschnabel commented 7 years ago

Yes, someone has to implement it into org-caldav. Should not be to hard, but someone has to do it.

rgemulla commented 7 years ago

I'll give it a shot.

rgemulla commented 7 years ago

I've attached a modification that syncs locations for any value of org-caldav-sync-changes-to-org other than timestamp-only (i.e., title-and-timestamp, title-only, and all).

Only minor modifications were needed; e.g., adding a an additional location element to eventdata.

Feel free to incorporate this change into org-caldav.

rgmacs-org-caldav-location.zip

grauschnabel commented 7 years ago

thanks for that, I will look at this later, but maybe you could do it with a pull request next time? That would be much easier to put it into it.

rgemulla commented 7 years ago

Sure!

This time I didn't edit org-caldav directly, but just overwrote some functions in a separate file that I load on startup. This was easiest for me, but I agree that this increases the burden of putting it in. Next time I'll use a pull request.

rgemulla commented 7 years ago

Any chance to get this integrated into org-caldav? I created pull request #124 to make things easier.

joranvar commented 7 years ago

Sorry for the reference-spam. I tried to rewrite @rgemulla's commit to remove the whitespace changes. Didn't notice that the many pushes and rebases would lead to this.

Titan-C commented 6 years ago

Is there any progress on this? Is it working?

grauschnabel commented 6 years ago

I think, not at the moment. How important is that for you?

-- Mag. Martin Kaffanke +43 650 4514224 http://www.kaffanke.at

-----Original Message----- From: "Óscar Nájera" notifications@github.com To: dengste/org-caldav org-caldav@noreply.github.com Cc: Martin m.kaffanke@gmail.com, Comment comment@noreply.github.com Sent: Fr., 30 März 2018 13:03 Subject: Re: [dengste/org-caldav] Location property synched to remote calendar, but not backwards (#123)

Is there any progress on this? Is it working?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/dengste/org-caldav/issues/123#issuecomment-377502555

rgemulla commented 6 years ago

Well, it's implemented in PR #124 and working on my machine without any problems since a couple of month. Unfortunately, org-caldav does not seem to be maintained anymore to that you may have to integrate that PR yourself if you want this functionality.

Titan-C commented 6 years ago

I just moved to a new city and having location appointments is becoming relevant. I was fine org-caldav not syncing location as it says on the readme, I would painfully load the events through the web interface when needed. My issues arises because caldav syncs from server to local file and skips the location, but the next sync it pushes/updates to server the events without location. Then I no more have the location available in the server and my other caldav client on the phone has no information of the location of the event.

rgemulla commented 6 years ago

As I mentioned, if you apply PR #124, location synchronization works both ways.

Another option is to require the content of the rgmacs-org-caldav-location.zip after loading org-caldav.

Titan-C commented 6 years ago

I applied pr #124 and is working. Thank you @rgemulla

bepolymathe commented 5 years ago

For me it doesn't work for synchronization with Nextcloud. Can it come from the interpretation by the Nextcloud server? cal --» org (OK) org --» cal (Not work)

The format is : 

:PROPERTIES:
  :ID:       Nextcloud-TB9J700F1J683DMH2QL8R
  :LOCATION: Adress
  :END:
  <2019-10-06 dim. 14:00-15:00>
bepolymathe commented 5 years ago

Could you confirm the issue ?