Closed jackkamm closed 1 year ago
Closed this issue as #264 fixes the byte-compile errors, and almost all the errors from package-lint.
There is still one error package-lint is reporting, which I'm seeking further guidance on here: https://github.com/purcell/package-lint/issues/240
I still think it's a good idea to switch to lexical binding (see [1]), but will save it for a possible future refactoring.
[1] https://www.gnu.org/software/emacs/manual/html_node/elisp/Coding-Conventions.html
Calling
byte-compile
yields a number of compilation warnings now.Some of these may be false positives due to use of dynamic binding (reference to free variable).
But we should probably switch to lexical binding anyways. We'll need to take care not to break anything if/when we do this.