search

denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
76 stars 48 forks source link

Merge refactored library changes into master #11

Closed denibertovic closed 8 years ago

denibertovic commented 8 years ago

This is was a huge ongoing effort to refactor the library. Huge props goes to @jprider63 without who this would probably take much much longer.

@jprider63 I'm opening a PR as to track the changes that are going to be merged more easily. And so there's some information for people that stumble on the library on github and wonder in what kind of state it is.

I think we can merge this as is but what's missing before we can do release are the following things:

  1. Documentation (we need a little more haddock and some basic usage/tutorial in the README)
  2. Review dependencies in the cabal file. I've been adding all sorts of things there while playing around and I'm not sure all of it is needed.
  3. Set version bounds in the cabal file.
  4. Add more tests (most importantly tests that check that we properly serialize/de-serialize json)
  5. Move to Docker.Client namespace (to follow more closely how the other libraries work).
denibertovic commented 8 years ago

Tests are green. I'm merging this for now and will open an issue for the points mentioned in the comment.