search

denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
76 stars 48 forks source link

Change the type of entrypoint to [Text] #22

Closed kseo closed 7 years ago

kseo commented 7 years ago

Entrypoint can be an array of strings.

jprider63 commented 7 years ago

It looks like entrypoint can either be a string, string array, or null. I don't think these changes to FromJSON ContainerConfig will work in all cases.

kseo commented 7 years ago

The Docker Remote API document says that entrypoint is either a string or an array of strings, but it seems to return null in the examples.

Entrypoint - Set the entry point for the container as a string or an array of strings.

So, I updated the PR to handle all three cases:

denibertovic commented 7 years ago

This should not have been closed. See here for explanation: #27