denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
76 stars 48 forks source link

requestUnit bug fix + test case #43

Closed jprider63 closed 7 years ago

jprider63 commented 7 years ago

This should fix #41 and maybe #39.

I added an integration test case for this too. I can't run integration tests with the configuration on my system, so hopefully it passes without issue.

SKoschnicke commented 7 years ago

It seems that your fix is already showing some other mistakes, great work! I fixed the failing test in #44

With this little addition, the integration tests run fine and your fix looks good!

denibertovic commented 7 years ago

Thanks @jprider63 I merged this and the test failure fix that @SKoschnicke did in #44