search

denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
77 stars 48 forks source link

fix null NetworkSettings.Ports #68

Closed backuitist closed 3 years ago

jprider63 commented 5 years ago

Thanks for the PR @backuitist! Do you have an example JSON test case that's failing?

I'm somewhat inclined to leave the type unchanged and change the PortBinding instance.

denibertovic commented 4 years ago

Hey @backuitist thanks for the PR. Do you mind adding a test for this change?

thoaionline commented 3 years ago

@denibertovic doesn't look like this needs a test as it's a derived type update.

This PR will fix #80

jprider63 commented 3 years ago

Closing in favor of #81 which doesn't change the types/API.