search

denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
77 stars 48 forks source link

building against LTS 15.0 #72

Closed esjmb closed 4 years ago

esjmb commented 4 years ago

Hi,

docker will not presently build as a dependency in projects using LTS-15.0, but there is an easy fix.

Line 1567 of src/Docker/Client/Types.hs, function parseIntegerText, just add MonadFail m to signature:

parseIntegerText :: (MonadFail m, Monad m) => Text -> m Integer
parseIntegerText t = case readMaybe $ T.unpack t of
    Nothing ->
        fail "Could not parse Integer"
    Just i ->
        return i

thanks for the great work, Stephen.

jprider63 commented 4 years ago

Thanks @esjmb! I just made PR #73 that includes this. I'll merge it once CI passes.

jprider63 commented 4 years ago

@denibertovic can you deploy the new version?

denibertovic commented 4 years ago

@jprider63 done! :)