Various improvements related to waitContainer

mbg commented 4 years ago

This PR consists of three commits which address #78 in various ways:

d3f961d212d640ce1203b90da7d93dcf94eee1ae simply documents the issue in waitContainer's documentation
b5cd7816656dc44fbfd18911a5f4c2b900f310e8 adds a new definition defaultUnixManagerSettings. This is just some code refactored out from unixHttpHandler so that unixHttpHandler "/var/run/docker.sock" is equivalent to:
```
let settings = defaultUnixManagerSettings "/var/run/docker.sock"
manager <- newManager settings
httpHandler manager
```
This allows the manager to be customised, e.g. to set a different timeout:
```
let settings = (defaultUnixManagerSettings "/var/run/docker.sock") {
managerResponseTimeout = responseTimeoutNone
}
manager <- newManager settings
httpHandler manager
```
015762aae3afbc0dd0a7a2d75a53dd51766f75ac is the most invasive commit and introduces a new function getEndpointTimeout which returns responseTimeoutDefault for all endpoints except WaitContainerEndpoint for which it returns responseTimeoutNone. This is then used in mkHttpRequest to set the value of responseTimeout for the request that is constructed.

I would think that the first two are fairly safe to merge, while the third one may require some thought.

mbg commented 2 years ago

Hi @denibertovic and @jprider63 👋🏻 this PR has been open for nearly two years now and I would still like to see something like this merged. Is there anything I can do to help this along? Do you need any help maintaining this library?

denibertovic commented 2 years ago

@mbg I'll take a look over the weekend and see if I can get this merged.

kk-hainq commented 2 years ago

This is awesome!

denibertovic commented 2 years ago

@mbg Finally got around to this. I don't have any particular strong opinion about this. But as you say if it works for you in practice for a while now I see no reason why we can't merge it. Thanks!

RobertFischer commented 2 years ago

Thanks for merging this.

On Tue, Mar 22, 2022, 00:16 Hai Nguyen Quang @.***> wrote:

This is awesome!

— Reply to this email directly, view it on GitHub https://github.com/denibertovic/docker-hs/pull/79#issuecomment-1074707611, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAE5V6WCYFUXFRVS2W5QHTVBFCQTANCNFSM4MBZAQBQ . You are receiving this because you commented.Message ID: @.***>

denibertovic / docker-hs

Various improvements related to waitContainer #79