search

denibertovic / docker-hs

A Haskell library for the Docker Engine API
BSD 3-Clause "New" or "Revised" License
77 stars 48 forks source link

Add support for pulling images from private registries #83

Open mrBliss opened 3 years ago

mrBliss commented 3 years ago

Fixes #82.

pullImage now takes a PullOpts argument, which includes an optional AuthConfig. For more details, see: https://docs.docker.com/engine/api/v1.41/#section/Authentication

mrBliss commented 3 years ago

It seems this project has no CI. Before submitting this PR, I successfully compiled this branch with all stack-*.yaml files in this repo (hence the choice for base64-bytestring library over the newer base64 library, which does not support GHC 7.10, IIRC).

I didn't add a test, as it would require setting up a private Docker registry, which is quite the effort. However, I did successfully test it with a private registry (using Credentials).

ocramz commented 7 months ago

@mrBliss @denibertovic the project now has CI, how can we move this PR forward? BTW @denibertovic I'd be happy to help if you don't have the bandwidth. Thanks!

denibertovic commented 7 months ago

@ocramz Sure thing. If you can resolve the conflicts in a new PR I'd be happy to merge. Also at this point I think we would be ok to drop support for 7.10 if it's too big of a hassle to support.