Support Aeson 2 - Githubissues

denibertovic / docker-hs

A Haskell library for the Docker Engine API

BSD 3-Clause "New" or "Revised" License

77 stars 48 forks source link

Support Aeson 2 #89

Closed mbg closed 2 years ago

mbg commented 2 years ago

This PR builds on #92 (so that should be merged first) and makes the following changes:

Docker.Client.Types is updated to support aeson >= 2 while still maintaining backwards compatibility with older versions
A small change to Docker.Client.Http to support GHC 9
Stack LTS-19 is the first to include GHC 9 and aeson >= 2, so I have added a configuration file for that and added it to the matrix build.
A second GHA workflow stackage-nightly is added which builds the library using the latest nightly resolver.

denibertovic commented 2 years ago

Thanks. :cake:

denibertovic commented 2 years ago

hey @mbg mind checking the tests on master that are failing? Is that to be expected?

mbg commented 2 years ago

@denibertovic Neither expected nor unexpected; it's the build with the most recent nightly Stack resolver (+ GHC 9.2.2), rather than one of the LTS resolvers (and supported GHC versions), so it may be a recent change in one of the dependencies/GHC.

I am a little puzzled though because I don't immediately see what's different between that build and the one with GHC 9.0.2 (e.g. the aeson version in both is the same). It's the tests that fail to compile. I will have a look though and see if it is an easy fix and, if so, open a PR with GHC 9.2 / nightly support.

mbg commented 2 years ago

(I should also note that the stackage-nightly workflow doesn't normally run when pushing to master, it normally only runs on a schedule and is therefore disconnected from commits. It only ran associated to a commit this time because the file defining it changed.)

mbg commented 2 years ago

Ah, lens-aeson (which is only used by the tests) got updated in the nightly Stack resolver to version 1.2 which includes breaking changes to its types.

mbg commented 2 years ago

@denibertovic I have opened https://github.com/denibertovic/docker-hs/pull/95 for this