search

denieler / save-workspace-atom-plugin

If you work with few projects same time this plugin give you the opportunity to change your workspace faster. Save your workspace, all your opened tabs, cursor position, etc. for each task you are working with.
MIT License
23 stars 5 forks source link

Error when opening saved workspace with 2 panes #13

Closed gsteigerwald closed 7 years ago

gsteigerwald commented 7 years ago

[Enter steps to reproduce below:]

  1. Create and save workspace with multiple panes
  2. Close atom
  3. Open the saved workspace

This throws an error that the pane was destroyed and all files opened in right pane are all now on the left pane. Also, when switching from one workspace to another, the original workspace's files are still open.

Atom Version: 1.13.1 Electron Version: 1.3.13 System: Mac OS X 10.12.2 Thrown From: save-workspace package, v0.2.9

Stack Trace

Uncaught Error: Pane has been destroyed

At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:832

Error: Pane has been destroyed
    at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:832:15)
    at Pane.module.exports.Pane.focus (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:240:21)
    at atom-pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:50:23)
    at HTMLInputElement.trigger (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4596:11)
    at Object.trigger (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4316:60)
    at HTMLInputElement.<anonymous> (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4901:17)
    at Function.each (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:374:23)
    at jQuery.each (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:139:17)
    at jQuery.trigger [as originalTrigger] (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4900:15)
    at jQuery.$.fn.trigger (/Users/Glenn/.atom/packages/save-workspace/node_modules/space-pen/lib/space-pen.js:606:19)
    at jQuery.fn.(anonymous function) [as focus] (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:7487:9)
    at SelectSavedWorkspaceView.module.exports.SelectListView.restoreFocus (/Users/Glenn/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:327:70)
    at SelectSavedWorkspaceView.close (/Users/Glenn/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:36:10)
    at SelectSavedWorkspaceView.cancelled (/Users/Glenn/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:48:10)
    at SelectSavedWorkspaceView.module.exports.SelectListView.cancel (/Users/Glenn/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:263:14)
    at atom-text-editor.<anonymous> (/Users/Glenn/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:76:26)
    at atom-text-editor.dispatch (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4435:9)
    at atom-text-editor.elemData.handle (/Users/Glenn/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4121:28)
    at atom-text-editor.TextEditorElement.inputNodeBlurred (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:239:21)
    at atom-pane.PaneElement.activated (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:113:19)
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:837:27)
    at PaneContainer.module.exports.PaneContainer.activateNextPane (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:252:26)
    at Pane.module.exports.Pane.destroyed (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:858:24)
    at Pane.module.exports.Model.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/model.js:31:58)
    at Pane.module.exports.Pane.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:851:39)
    at Workspace.open (/Users/Glenn/.atom/packages/save-workspace/lib/models/workspace.js:14:17)
    at Open.<anonymous> (/Users/Glenn/.atom/packages/save-workspace/lib/commands/open.js:18:22)
    at SelectSavedWorkspaceView.confirmed (/Users/Glenn/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:42:10)
    at SelectSavedWorkspaceView.module.exports.SelectListView.confirmSelection (/Users/Glenn/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:338:21)
    at space-pen-div.atom.commands.add.core:confirm (/Users/Glenn/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:109:19)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:259:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:59)

Commands

     -0:03.3.0 save-workspace:open (input.hidden-input)
     -0:02.7.0 core:move-down (input.hidden-input)
     -0:02.4.0 core:move-up (input.hidden-input)
     -0:01.4.0 core:backspace (input.hidden-input)
     -0:00.8.0 core:move-down (input.hidden-input)
     -0:00.6.0 core:move-up (input.hidden-input)
     -0:00.4.0 core:confirm (input.hidden-input)

Config

{
  "core": {}
}

Installed Packages

# User
git-diff-details, v1.4.0 (active)
language-babel, v2.49.4 (active)
minimap, v4.26.7 (active)
save-workspace, v0.2.9 (active)
atom-dark-syntax, v0.28.0 (inactive)
atom-dark-ui, v0.53.0 (inactive)
atom-light-syntax, v0.29.0 (inactive)
atom-light-ui, v0.46.0 (inactive)
base16-tomorrow-dark-theme, v1.4.0 (inactive)
base16-tomorrow-light-theme, v1.4.0 (inactive)
one-dark-ui, v1.8.2 (active)
one-light-ui, v1.8.2 (inactive)
one-dark-syntax, v1.6.0 (active)
one-light-syntax, v1.6.0 (inactive)
solarized-dark-syntax, v1.1.1 (inactive)
solarized-light-syntax, v1.1.1 (inactive)
about, v1.7.2 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.14.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.33.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.29.0 (inactive)
autosave, v0.23.2 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.43.2 (active)
bracket-matcher, v0.85.1 (active)
command-palette, v0.39.1 (inactive)
deprecation-cop, v0.55.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.204.5 (active)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.2.0 (active)
go-to-line, v0.31.2 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.1 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.159.3 (active)
metrics, v1.1.3 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.2 (inactive)
settings-view, v0.244.0 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.5 (active)
status-bar, v1.6.0 (active)
styleguide, v0.48.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.1 (active)
timecop, v0.33.2 (active)
tree-view, v0.211.1 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.39.0 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.1 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages
denieler commented 7 years ago

@gsteigerwald this issue should be fixed in 0.4 version, try it please. Thanks for posting this bug!