search

denieler / save-workspace-atom-plugin

If you work with few projects same time this plugin give you the opportunity to change your workspace faster. Save your workspace, all your opened tabs, cursor position, etc. for each task you are working with.
MIT License
23 stars 5 forks source link

Workspace.get is deprecated. #20

Closed xream closed 6 years ago

xream commented 7 years ago

atom.workspace.paneContainer has always been private, but it is now gone. Please use atom.workspace.getCenter() instead and consult the workspace API docs for public methods.

Workspace.get (<embedded>:24605:18)
Workspace.save (/Users/xream/.atom/packages/save-workspace/lib/models/workspace.js:46:41)
Save.<anonymous> (/Users/xream/.atom/packages/save-workspace/lib/commands/save.js:38:25)
InputWorkspaceNameView.cancelled (/Users/xream/.atom/packages/save-workspace/lib/input-workspace-name-view.js:70:12)
InputWorkspaceNameView.cancel (/Users/xream/.atom/packages/tab-numbers/node_modules/atom-space-pen-views/lib/select-list-view.js:263:14)
InputWorkspaceNameView.confirmSelection (/Users/xream/.atom/packages/tab-numbers/node_modules/atom-space-pen-views/lib/select-list-view.js:340:21)
denieler commented 7 years ago

@xream when this object is going to be deprecated? I can't find any reference in docs - https://atom.io/docs/api/v1.6.0/Workspace

xream commented 7 years ago

I'm using Atom 1.17 beta. Maybe it'll be deprecated in the next stable release.

0x4156-AV commented 7 years ago

Please Fix

ghost commented 6 years ago

Same issue

er-vin commented 6 years ago

I confirm it's still there.

denieler commented 6 years ago

@AaronVigal @ernest35 @er-vin @xream hey guys! I really appreciate that you are using this plugin and I hope it helps you on daily basis. If this bug is still actual and can be easily reproduced - I will prioritize this issue to be fixed as soon as possible. Thanks! Also, I will be really thankful and it will be easier to find the bug if you will write your steps to reproduce this issue.

er-vin commented 6 years ago

It works, it's just that I'm being pestered by Atom's Deprecation Cop. When you install the save-workspace package you see in the status bar the mention "1 deprecation" with details when you click on it.

ghost commented 6 years ago

Agree with @er-vin - the plugin seems to work as expected but Atom's Deprecation Cop flags it as an issue.

I'm using Atom 1.24.0 x64

camdagr8 commented 6 years ago

+1 fix please.. this package is exactly what I needed!

denieler commented 6 years ago

Fixed with #27 and available in release v.0.5.0

Thank you guys for waiting so long! And please post if you will have any other issues connected to this one or any other.