search

denieler / save-workspace-atom-plugin

If you work with few projects same time this plugin give you the opportunity to change your workspace faster. Save your workspace, all your opened tabs, cursor position, etc. for each task you are working with.
MIT License
23 stars 5 forks source link

Uncaught Error: Pane has been destroyed #6

Closed hefler closed 7 years ago

hefler commented 8 years ago

I'm using Save-workspace to restore all opened files when I switch back and forth from Git branches. So when I restored a saved workspace got an error. That's what I was doing:

  1. Saved a workspace.
  2. Switched to a different working branch
  3. Finished working on that branch
  4. Switched back to the initial branch
  5. Opened the saved workspace.
  6. BOOM! Got the error.

Atom Version: 1.10.0 Electron Version: 0.37.8 System: Mac OS X 10.12 Thrown From: save-workspace package, v0.2.8

Stack Trace

Uncaught Error: Pane has been destroyed

At /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:828

Error: Pane has been destroyed
  at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:828:15)
  at Pane.module.exports.Pane.focus (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:236:21)
  at atom-pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:50:23)
  at atom-text-editor.jQuery.event.special.focus.trigger (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4596:11)
  at Object.jQuery.event.trigger (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4316:60)
  at atom-text-editor.<anonymous> (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4901:17)
  at Function.jQuery.extend.each (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:374:23)
  at jQuery.fn.jQuery.each (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:139:17)
  at jQuery.fn.extend.trigger [as originalTrigger] (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4900:15)
  at $.fn.trigger (/Users/hefler/.atom/packages/save-workspace/node_modules/space-pen/lib/space-pen.js:606:19)
  at jQuery.fn.(anonymous function) [as focus] (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:7487:9)
  at SelectSavedWorkspaceView.module.exports.SelectListView.restoreFocus (/Users/hefler/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:327:70)
  at SelectSavedWorkspaceView.close (/Users/hefler/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:53:12)
  at SelectSavedWorkspaceView.cancelled (/Users/hefler/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:67:12)
  at SelectSavedWorkspaceView.module.exports.SelectListView.cancel (/Users/hefler/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:263:14)
  at atom-text-editor.<anonymous> (/Users/hefler/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:76:26)
  at atom-text-editor.jQuery.event.dispatch (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4435:9)
  at atom-text-editor.elemData.handle (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4121:28)
  at atom-pane.PaneElement.activated (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:113:19)
  at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
  at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:833:27)
  at PaneContainer.module.exports.PaneContainer.activateNextPane (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:250:26)
  at Pane.module.exports.Pane.destroyed (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:854:24)
  at Pane.module.exports.Model.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/model.js:31:58)
  at Pane.module.exports.Pane.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:847:39)
  at Object.openWorkspace (/Users/hefler/.atom/packages/save-workspace/lib/save-workspace.js:116:19)
  at SelectSavedWorkspaceView.confirmed (/Users/hefler/.atom/packages/save-workspace/lib/select-saved-workspace-view.js:60:12)
  at SelectSavedWorkspaceView.module.exports.SelectListView.confirmSelection (/Users/hefler/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:338:21)
  at HTMLLIElement.<anonymous> (/Users/hefler/.atom/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:139:19)
  at HTMLOListElement.jQuery.event.dispatch (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4435:9)
  at HTMLOListElement.elemData.handle (/Users/hefler/.atom/packages/save-workspace/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -0:03.3.0 save-workspace:open (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig"
      ],
      "source.json": [
        ".arcconfig",
        "BUCK.autodeps"
      ],
      "source.python": [
        "BUCK"
      ]
    },
    "disabledPackages": [
      "tree-view"
    ]
  }
}

Installed Packages

# User
angularjs, v0.3.5 (active)
angularjs-styleguide-snippets, v0.7.3 (active)
docblockr, v0.8.5 (active)
emmet, v2.4.3 (active)
filesize, v0.4.2 (active)
floobits, v0.32.4 (active)
git-plus, v5.16.2 (inactive)
js-hyperclick, v1.4.2 (active)
js-patterns-atom-snippets, v0.2.1 (active)
minimap, v4.24.7 (active)
nuclide, v0.165.0 (active)
open-this, v0.2.0 (inactive)
pigments, v0.34.0 (active)
save-workspace, v0.2.8 (active)
Sublime-Style-Column-Selection, v1.7.2 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.5.0 (active)
one-light-ui, v1.5.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.3 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
find-and-replace, v0.201.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.2 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v0.53.1 (active)
notifications, v0.65.0 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.241.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.100.2 (active)
timecop, v0.33.2 (active)
tree-view, v0.208.2 (inactive)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages
denieler commented 8 years ago

@hefler thanks for your issue! I'll take a look at this bug today and try to fix as soon as possible

byg0n3 commented 7 years ago

Hey there. Any news on the issue? Just got same error.

Steps are:

  1. Saved workspace#1 with one window (main workspace, no split here)
  2. Saved workspace#2 with two windows up and horizontal split
  3. Switched to workspace#2, made some changes to files, saved
  4. Switched back workspace#1 (same branch)
  5. Error

Atom: 1.15.0 x64 Electron: 1.3.13 OS: Linux Mint Thrown From: save-workspace package 0.2.9

Stack Trace

Uncaught Error: Pane has been destroyed

At /opt/atom/resources/app.asar/src/pane.js:847

Error: Pane has been destroyed
    at Pane.module.exports.Pane.activate (/app.asar/src/pane.js:847:15)
    at Pane.module.exports.Pane.focus (/app.asar/src/pane.js:252:21)
    at /app.asar/src/pane-element.js:50:23)
    at HTMLInputElement.trigger (/packages/save-workspace/node_modules/jquery/dist/jquery.js:4596:11)
    at Object.trigger (/packages/save-workspace/node_modules/jquery/dist/jquery.js:4316:60)
    at /packages/save-workspace/node_modules/jquery/dist/jquery.js:4901:17)
    at Function.each (/packages/save-workspace/node_modules/jquery/dist/jquery.js:374:23)
    at jQuery.each (/packages/save-workspace/node_modules/jquery/dist/jquery.js:139:17)
    at /packages/save-workspace/node_modules/jquery/dist/jquery.js:4900:15)
    at /packages/save-workspace/node_modules/space-pen/lib/space-pen.js:606:19)
    at /packages/save-workspace/node_modules/jquery/dist/jquery.js:7487:9)
    at SelectSavedWorkspaceView.module.exports.SelectListView.restoreFocus (/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:327:70)
    at SelectSavedWorkspaceView.close (/packages/save-workspace/lib/select-saved-workspace-view.js:36:10)
    at SelectSavedWorkspaceView.cancelled (/packages/save-workspace/lib/select-saved-workspace-view.js:48:10)
    at SelectSavedWorkspaceView.module.exports.SelectListView.cancel (/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:263:14)
    at /packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:76:26)
    at /packages/save-workspace/node_modules/jquery/dist/jquery.js:4435:9)
    at /packages/save-workspace/node_modules/jquery/dist/jquery.js:4121:28)
    at /app.asar/src/text-editor-element.js:244:21)
    at /app.asar/src/pane-element.js:113:19)
    at Function.module.exports.Emitter.simpleDispatch (/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at Pane.module.exports.Pane.activate (/app.asar/src/pane.js:852:27)
    at PaneContainer.module.exports.PaneContainer.activateNextPane (/app.asar/src/pane-container.js:252:26)
    at Pane.module.exports.Pane.destroyed (/app.asar/src/pane.js:873:24)
    at Pane.module.exports.Model.destroy (/app.asar/src/model.js:31:58)
    at Pane.module.exports.Pane.destroy (/app.asar/src/pane.js:866:39)
    at Workspace.open (/packages/save-workspace/lib/models/workspace.js:14:17)
    at /packages/save-workspace/lib/commands/open.js:18:22)
    at SelectSavedWorkspaceView.confirmed (/packages/save-workspace/lib/select-saved-workspace-view.js:42:10)
    at SelectSavedWorkspaceView.module.exports.SelectListView.confirmSelection (/packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:338:21)
    at /packages/save-workspace/node_modules/atom-space-pen-views/lib/select-list-view.js:109:19)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:259:29)
    at /app.asar/src/command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:599:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:390:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/app.asar/src/window-event-handler.js:106:36)
    at /app.asar/src/window-event-handler.js:3:59)

Commands

     -2:30.6.0 intentions:highlight (input.hidden-input)
  5x -2:27.7.0 core:backspace (input.hidden-input)
  2x -1:57.1.0 core:move-right (input.hidden-input)
     -1:56.2.0 core:delete (input.hidden-input)
 13x -1:54.2.0 core:backspace (input.hidden-input)
     -1:29.9.0 core:move-up (input.hidden-input)
  2x -1:29.6.0 core:move-left (input.hidden-input)
     -1:15.2.0 intentions:highlight (input.hidden-input)
     -1:15.1.0 core:save (input.hidden-input)
     -1:14.4.0 intentions:highlight (input.hidden-input)
     -1:14.3.0 core:save (input.hidden-input)
     -1:12.6.0 intentions:highlight (input.hidden-input)
     -1:12.4.0 application:open-folder (input.hidden-input)
     -1:10.5.0 intentions:highlight (input.hidden-input)
     -1:10.4.0 save-workspace:open (input.hidden-input)
     -1:09.3.0 core:confirm (input.hidden-input)

Non-Core Packages

autocomplete-python 1.8.62 
busy-signal 1.3.0 
hyperclick 0.0.40 
intentions 1.1.2 
language-docker 1.1.7 
language-ignore 1.5.2 
linter 2.1.2 
linter-jsonlint 1.3.0 
linter-pycodestyle 2.0.2 
linter-pylint 1.2.3 
linter-ui-default 1.2.2 
MagicPython 1.0.7 
minimap 4.26.8 
pigments 0.39.1 
platformio-ide-terminal 2.5.0 
python-indent 1.0.2 
python-isort 0.0.7 
python-tools 0.6.9 
save-workspace 0.2.9 
snippets-gitignore 0.0.1 
sort-lines 0.14.0 
sync-settings 0.8.1 
todo-show 1.11.0 
xml-formatter 0.10.0
denieler commented 7 years ago

hey @dein0s! we didn't have an opportunity to reproduce this issue, that's why it is still opened :(

we will take a look on your flow, thank you for reporting!

denieler commented 7 years ago

Seems that these issues are connected - atom/atom#4643

denieler commented 7 years ago

@hefler @dein0s guys, seems that bug has been fixed with https://github.com/denieler/save-workspace-atom-plugin/commit/4819d60e40cce51f55f48744c2e60def18c48b4a . Tell me please if you will have this problem again or any other issues. Thanks!