denilsonsa / prettyping

`prettyping` is a wrapper around the standard `ping` tool, making the output prettier, more colorful, more compact, and easier to read.
http://denilsonsa.github.io/prettyping/
MIT License
1.21k stars 78 forks source link

Doesn't handle duplicate responses #37

Open acronce opened 10 months ago

acronce commented 10 months ago

While diagnosing a local networking problem I found that prettyping doesn't handle duplicate ping messages. With the base ping tool I was periodically seeing output like this:

64 bytes from 0.0.0.0: icmp_seq=56890 ttl=64 time=1.174 ms (DUP!)

During this time I had prettyping running side by side in another window. It showed no indication of duplicate responses happening.

Note that I saw this comment in the script:

# TODO? How will prettyping behave if it receives a duplicate response?

I think the current answer is that prettyping does not handle duplicate responses.

It looks like ping considers duplicates a warning. But searching online seems to indicate that duplicates are unexpected, and often associated with link level problems.

It seems like prettyping should recognize duplicates, possibly as an error, and somehow display them.