denim-squad / jean-around-the-world

For CPSC 436I
GNU General Public License v3.0
2 stars 1 forks source link

Make loading spinner run for a dynamic amount of time #104

Closed pwesferguson closed 5 years ago

pwesferguson commented 5 years ago

Does the loading spinner disappear once the page has finished loading? If that's the case, I would actually prefer what we had before. The timings from before were to show off the animation that Jessica created. The best practice would be to refactor the loading spinner component into redux and hide it in componentDidMount()s.

navigate around on the deployed app and see if you feel the same way. Jessica's animation is really good, but I really disliked having to sit through the same amount of time before the page actually started loading. The final unravel the travel button should generally run the gif for a reasonable amount of time, or we could enforce some minimum to ensure that the animation gets shown off sufficiently.