denimnani / service.subloader

Kodi automatic subtitles
Other
34 stars 12 forks source link

When playing something with PVR IPTV and "Exclude live TV" in settings is set, the subtitle search is still done and the popup window to ask for a subtitle appears #9

Open peno64 opened 4 years ago

peno64 commented 4 years ago

I fixed it by changing exclusions.py by adding the following code in pathexlusions routine:

if (videosource().find("pvr://") > -1) and boolsetting('excludelivetv'):
    debug('Video is playing via Live TV, which is currently set as excluded location.')
    return False

This is the code extract:

def pathexclusion():

debug('Content path: %s' % videopath())
if videopath().find("http://") > -1 or videopath().find("https://") > -1:
    debug('Content source: %s' % videosource())

if (videosource().find("pvr://") > -1) and boolsetting('excludelivetv'):
    debug('Video is playing via Live TV, which is currently set as excluded location.')
    return False

if not videopath():
    return False

. . .

denimnani commented 4 years ago

Hi there, can you reproduce the issue and send me the log? Don't forget to activate the debug mode. This should not happen, either way need to look at the log, since I can't test with pvr, i simply don't use it ;)

peno64 commented 4 years ago

This is a part of the log when this happens:

2020-10-23 18:43:06.636 T:2740978544 NOTICE: #####[SubLoader]##### Content path: https://live-cf-vrt.akamaized.net/groupc/live/8edf3bdf-7db3-41c3-a318-72cb7f82de66/live.isml/.mpd 2020-10-23 18:43:06.643 T:2740978544 NOTICE: #####[SubLoader]##### Content source: pvr://channels/tv/All channels/

peno64 commented 4 years ago

This is caused by a new Belgian addon called iptv manager which is in the official kodi repo and it allows to play streams from addons via the tv manager. So the program is chosen in the pvr tv manager and it gets the stream via an addon whict in this case is vrt nu, a belgium addon to play the streams from the Belgium television.

denimnani commented 4 years ago

I see it now, this addon make impossible for this particular setting work properly because the actual sorce is http, that means Subloader is not detecting as PVR, you can temporarily do 1 of 2 things: 1 set the setting to exclude http sorces to on, and your problem is solved without change any code, but this have an undesirable effect if you use any movie streaming addon the Subloader will not start, option 2 you can try in exclusion, exclude addon select iptv manager an see if works. Either way i will need to test properly with that especific addon and try to figure out a solution. Let me know if any of those options work for you.

peno64 commented 4 years ago

Option 1 is indeed not a possibility. Option 2 is also not possible out of the box because iptv manager is not in the list of addons you show. I think you only show video addons. So I edited your settings.xml file and added the addon name there manually: service.iptv.manager As you can see it is a service. But even that didn't work.

So I added the following statement in the code:

def addonexclusion():

if setting('excludeaddon'):
            debug('The source addon is: %s' % videosource())

. . .

And it says:

2020-10-24 08:43:50.806 T:2739499888 NOTICE: #####[SubLoader]##### The source addon is: pvr://channels/tv/All channels/

Adding that manually in settings.xml works...

<setting id="excludeaddon">plugin.video.retrospect,plugin.video.viervijfzes,plugin.video.vrt.nu,plugin.video.vtm.go,plugin.video.yelo,plugin.video.youtube,pvr://channels/tv/All channels/</setting>

So this is a solution but each time I add a new addon via the UI I will loose that setting and I will have to manually add it again. Which is not a big problem.

denimnani commented 4 years ago

First of all i want to thank you, you actually did a great job trouble shooting the addon, unfortunately not all issues are as clear as this :) , i will add in the next update a correction for this issue.