denio7 / egit

Automatically exported from code.google.com/p/egit
0 stars 0 forks source link

Team/Commit action is incredibly slow #101

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. get around 40 egit-connected projets in your workspace
2. just change a few characters in 2 files
3. right click on the 2 projects containing the files, pick "commit"

I have no feedback at all and get the "commit" dialog after more than 1
minute. I would have expected a few second latency at most.

What version of the product are you using? On what operating system?
I'm using the egit trunk on Linux as of the 26 June 2009.

Please provide any additional information below.

Using a Java profiler, I can see that most of the time (80%) is spent in
IndexDiff$1.visitEntry and more especially GitIndex$Entry.isModified()
calling File.exists(), File.length(), File.isFile() and File.lastModified()
which are used a lot. That's really a bold analysis, I'll try to digg further..

Attached is the corresponding Yourkit profiling snapshot

Original issue reported on code.google.com by cedric.b...@gmail.com on 26 Jun 2009 at 2:14

Attachments:

GoogleCodeExporter commented 8 years ago
I cannot read the attachment, but I have noticed that commit may be slow 
sometimes and
especially so on windows. From your analysis it appears we are doing too much 
work.
This sounds reasonable. We haven't done any optimization here. 

I agree that this performance issue is bad enough to qualify as a bug.

Original comment by robin.ro...@gmail.com on 26 Jun 2009 at 7:41

GoogleCodeExporter commented 8 years ago
I don't know if this is the same bug, but using EGit 0.5.0, when I try to add 
files to 
Git or commit my changes, the process takes ages even for a single small 
project.
While EGit is committing or adding I notice that in the projects .git directory
the file index.tmp gets created and immediately deleted again, while the index 
file is 
constantly shrinking in size.

Original comment by Martin.Mauch@gmail.com on 2 Jul 2009 at 10:31

GoogleCodeExporter commented 8 years ago
I don't think we need any more analysis here. Patches we need. Part one of that 
patch
set would be to stop using the old GitIndex class completely, but more than 
that may
be needed and any further analysis should by done on the DirCache classes once 
commit
starts using them,

Original comment by robin.ro...@gmail.com on 2 Jul 2009 at 3:36

GoogleCodeExporter commented 8 years ago
Fixed in dcd931cb2f0d39bb9cfbb4d2206fe08e34eeaed9

Original comment by robin.ro...@gmail.com on 13 Jul 2010 at 8:58

GoogleCodeExporter commented 8 years ago
This bug is marked as 'fixed.'  But I'm experiencing painful latency running 
the commit operation.

I have one project connected with Egit.  And whenever I choose "Commit" from 
the Team menu, it takes a full minute before the dialog opens.

I'm using the Egit nightly build 0.9.0.20100812 on Mac/Helios.

Original comment by inertia1...@gmail.com on 13 Aug 2010 at 10:00